Update to controller-runtime 0.5.0 #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* And K8S 1.17 libraries
This has now been fixed upstream.
wallrj
commented
Feb 14, 2020
| @@ -58,6 +61,7 @@ func main() { | |||
| Scheme: scheme, | |||
| MetricsBindAddress: metricsAddr, | |||
| LeaderElection: enableLeaderElection, | |||
| LeaderElectionID: leaderElectionID, | |||
There was a problem hiding this comment.
You can see the effect of this in the controller logs:
2020-02-14T10:50:24.031Z INFO setup starting manager
I0214 10:50:24.031598 1 leaderelection.go:242] attempting to acquire leader lease eco-system/etcd-cluster-operator-controller...
2020-02-14T10:50:24.031Z INFO controller-runtime.manager starting metrics server {"path": "/metrics"}
I0214 10:50:24.039249 1 leaderelection.go:252] successfully acquired lease eco-system/etcd-cluster-operator-controller
2020-02-14T10:50:24.039Z DEBUG controller-runtime.manager.events Normal {"object": {"kind":"ConfigMap","namespace":"eco-system","name":"etcd-cluster-operator-controller","uid":"d989e918-ff9c-482a-85dd-66cb544cec58","apiVersion":"v1","resourceVersion":"788"}, "reason": "LeaderElection", "message": "eco-controller-manager-798b645f4c-tdc7f_3053e6bf-faf3-4a60-931f-6b631e56d797 became leader"}
There was a problem hiding this comment.
Vs
020-02-13T14:32:06.498Z DEBUG controller-runtime.manager.events Normal {"object": {"kind":"ConfigMap","namespace":"eco-system","name":"controller-leader-election-helper","uid":"1ce476d2-1d45-4ff7-94d0-5fa875e6b8c6","apiVersion":"v1","resourceVersion":"770"}, "reason": "LeaderElection", "message": "eco-controller-manager-798b645f4c-rbj65_422dbcf3-1f0b-4453-b74c-ae0a2af3cf05 became leader"}
There was a problem hiding this comment.
I've added -leader-election-helper back in to the name, to make it clear what the configmap is used for
cheahjs
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.5.0